This repository was archived by the owner on Apr 9, 2025. It is now read-only.
Translator on current builder #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We set our own translator in the translators defined by other extensions, but also for the current builder. It may happen that there is an extension that defines two translators for `dirhml` and `json`, and we are going to override them --the problem comes when `sphinx-build` is called with `-b custombuilder` since we weren't overriding it in that case. This commit override the ones defined by the user, but also the default one.
ericholscher
approved these changes
Apr 15, 2020
It differs in Sphinx1.8 and the rest. So, forcing its name to be always the same in tests.
|
@ericholscher I updated this PR with,
|
It does not make sense to override the domain classes when using other non-HTML builders because there is nothing to add. Although, due to a initialization race condition, we are not able to "not override the Domains if the builder is non-HTML" so we need to skip our custom resolution during build time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We set our own translator in the translators defined by other extensions, but
also for the current builder.
It may happen that there is an extension that defines two translators for
dirhmlandjson, and we are going to override them --the problem comes whensphinx-buildis called with-b custombuildersince we weren't overriding itin that case.
This commit override the ones defined by the user, but also the default one.
NOTE: the diff is a little tricky. I only removed an indentation level (to remove the first if) and swap the for/if blocks. There is no other changes.